Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use homebrew's mupdf if deps directory is empty #67

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

botantony
Copy link
Contributor

fixes #66

@freref
Copy link
Owner

freref commented Feb 28, 2025

Wouldn't it be better to check if mupdf is installed and if it is, we dynamically link, and if it isn't, we static link? I assume homebrew installs mupdf before fancy cat if fancy cat depends on mupdf? (Thanks for your contribution btw)

@botantony
Copy link
Contributor Author

i thought you wanted libraries to be statically linked and use dynamic links as a last resort

@freref
Copy link
Owner

freref commented Feb 28, 2025

I don't mind dynamic linking. I added static linking for ease of distribution, but if there is a way of checking if the user's system has the required dependencies, I don't see why we wouldn't dynamic link

@freref
Copy link
Owner

freref commented Feb 28, 2025

I dont mind merging this for now until I find a better way of doing things, is that ok for you?

@botantony
Copy link
Contributor Author

What do you think about using pkg-config to find mupdf? In case if pkg-config or mupdf doesn't exist we can use vendored dependecies

@freref
Copy link
Owner

freref commented Feb 28, 2025

I can't think of an elegant solution to this, for now this is fine, thank you

@freref freref merged commit a67b513 into freref:master Feb 28, 2025
4 checks passed
@botantony botantony deleted the mupdf branch February 28, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error: release tag doesn’t have mupdf submodule
2 participants